[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_fs_fs: The file system check function should beconsistent

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-04-02 14:03:46 CEST

On Mon, Apr 02, 2007 at 04:09:56PM +0530, Bhuvaneswaran Arumugam wrote:
> In FSFS file system check function, svn_fs_fs__check_fs(), we check for
> fs->path variable, while in the BDB counterpart, svn_fs_base__check_fs()
> function we check for fs->fsap_data variable to check the file system.

I do wonder whether there's actually any benefit to these checks at all,
given that the only way a caller [1] could trigger them would be to call
svn_fs_new() directly, and even then, the cause'd be pretty obvious even
if we didn't have the check.

[1] Other than fs-loader.c, which I'd argue is trivially verifiable by

But <shrug>, +1 to commit, assuming you've tested it.


  • application/pgp-signature attachment: stored
Received on Mon Apr 2 14:04:12 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.