Re: [PATCH] libsvn_fs_util: New library to reuse FSFS and BDBfunctions

On Mon, 02 Apr 2007, Malcolm Rowe wrote:

> On Mon, Apr 02, 2007 at 04:55:43PM +0530, Bhuvaneswaran Arumugam wrote:
> > List of redundant functions in libsvn_fs_fs/dag.c &
> > libsvn_fs_base/dag.c:
>
> Some of these functions need access to the per-fs dag_node_t type, so
> can't be shared.

Count those out, then.

> > List of redundant functions in libsvn_fs_fs/err.c &
> > libsvn_fs_base/err.c:
>
> (Incidentally, these might be better as macros - so that the line number
> of the caller is reported. I don't know what anyone else thinks).

Great point, Malcolm. All the functions in both files would be better
as macros. Bhuvan, this would be a good next step.

> > List of redundant functions in libsvn_fs_fs/id.c & libsvn_fs_base/id.c:
>
> These need access to the id_private_t type, which isn't shared between
> FSFS and BDB.

Count those out too.

> > List of redundant functions in libsvn_fs_fs/lock.c &
>
> I'm actually suprised that the entire locking subsystem isn't shared -
> isn't the implementation absolutely identical?

If they once were, they seem to have diverged somewhat. It would be
nice to share what code we can between'em, though.