Re: [PATCH] libsvn_fs_util: New library to reuse FSFS and BDBfunctions

On Mon, Apr 02, 2007 at 04:55:43PM +0530, Bhuvaneswaran Arumugam wrote:
> List of redundant functions in libsvn_fs_fs/dag.c &
> libsvn_fs_base/dag.c:

Some of these functions need access to the per-fs dag_node_t type, so
can't be shared.

> List of redundant functions in libsvn_fs_fs/err.c &
> libsvn_fs_base/err.c:

(Incidentally, these might be better as macros - so that the line number
of the caller is reported. I don't know what anyone else thinks).

> List of redundant functions in libsvn_fs_fs/id.c & libsvn_fs_base/id.c:

These need access to the id_private_t type, which isn't shared between
FSFS and BDB.

> List of redundant functions in libsvn_fs_fs/lock.c &

I'm actually suprised that the entire locking subsystem isn't shared -
isn't the implementation absolutely identical?

Regards,
Malcolm