[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 2732 (was Unhandled exception when stopping apache)

From: D.J. Heap <djheap_at_gmail.com>
Date: 2007-04-01 23:38:24 CEST

On 4/1/07, Branko ibej <brane@xbc.nu> wrote:
[snip]
>
> It would require a libsvn_fs initialization function that the all FS
> users are required to call ... which requires a change of contract that
> we can't enforce in 1.x. That's the main reason why the BDB pool init
> and teardown code is so horribly convoluted. :\
>

Yeah...it looks like it's already 'encouraged' if not required,
though, and then we do a 'best-effort' if we detect that it hasn't
been called.

Hmm, maybe there's a much simpler answer:

Move the cache initting code from svn_fs_bdb__init to
base_serialized_init where we already have the common_pool as a
parameter.

If my understanding is correct, svn_fs_bdb__init is used to init the
whole module, and base_serialized_init is used to init an svn_fs_t.
It seems like that is still early enough to init the cache, though,
isn't it?

DJ
Received on Sun Apr 1 23:38:36 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.