[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 2732 (was Unhandled exception when stopping apache)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2007-04-01 23:16:49 CEST

D.J. Heap wrote:
> On 4/1/07, Branko Čibej <brane@xbc.nu> wrote:
> [snip]
>> I suppose we could, if such hooks are available -- but then we'd have to
>> propagate that pool somehow to the libsvn_fs_bdb cache.
> I *think* they are there, and the common_pool already uses them from
> what I can tell -- in libsvn_fs\fs-loader.c, svn_fs_initialize and
> uninit seem to get called at the times I would expect.
> Propagating it to the bdb cache is the part that I'm not sure how to
> do. Would it require a new vtable entry (init2 that takes a pool) and
> then checking the module version to make sure it implemented that
> entry...or something like that?

It would require a libsvn_fs initialization function that the all FS
users are required to call ... which requires a change of contract that
we can't enforce in 1.x. That's the main reason why the BDB pool init
and teardown code is so horribly convoluted. :\

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 1 23:17:14 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.