[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PROPOSAL] Change of convention for multiline string literals

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-03-18 19:59:13 CET

Ivan Zhakov wrote:
> On 3/18/07, Jonathan Gilbert <o2w9gs702@sneakemail.com> wrote:
>> At 10:11 PM 3/10/2007 -0600, I wrote:
>> >Hello,
>> >
>> >I would like to propose a change to the way multiline string
>> literals are
>> >expressed, such as where the default text of a configuration file is
>> being
>> >compiled in as a single string literal.
>> [snip]
>> >The attached patch contains no semantic changes; it simply defines
>> SVN_NL
>> >and replaces APR_EOL_STR with it, and reformats all giant multi-line
>> string
>> >literals into a much more readable format (in my opinion, at least).
>>
>> Any chance of getting this patch applied? I'd much prefer to be working
>> with a sane inline file string literal format for the new authz test
>> cases.
> Hi Jonathan,
> I'm ready to apply this patch, but I want some arguments to align
> SVN_NL to length of longest line. I prefer do not do this, because
> it's easier to lost them out of screen in this case. I'll apply your
> patch as is, if you give me some arguments for your approach.
>
I have two small remarks on this patch:
1. Why not use EOL instead of SVN_NL?
2. A lot of the lines ending with SVN_NL are now >80 characters. Now
personally I don't care, and the guidelines in hacking allow that for
large text messages, but maybe we can avoid it.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 18 19:59:32 2007

This is an archived mail posted to the Subversion Dev mailing list.