[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23856 - in trunk/subversion: include libsvn_wc

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-03-16 00:33:53 CET

On 3/15/07, Peter Lundblad <plundblad@google.com> wrote:
> dionisos@tigris.org writes:
> > Modified: trunk/subversion/libsvn_wc/README
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/README?pathrev=23856&r1=23855&r2=23856
> > ==============================================================================
> > --- trunk/subversion/libsvn_wc/README (original)
> > +++ trunk/subversion/libsvn_wc/README Thu Mar 15 13:47:20 2007
> > @@ -486,7 +486,12 @@
> > working-size:
> > The number of bytes in the working file. This can differ from the
> > number of bytes in the text base; for example, the working file may
> > - have undergone keyword substitution or eol translation.
> > + have undergone keyword substitution or eol translation. -1 means
> > + the value isn't present in the working copy entries file. -2 means
> > + the actual value couldn't be calculated because the working copy
> > + file was locally modified.
>
> I'm still doubtful to whether we need this distinction or not, but just for
> the record,

Well, now that we clean the timestamp too, there's probably no reason
to keep the distinction.

> if we keep it, why use these ugly
> negative numeric constants in a file format that uses
> mnemonic words for all other enumerated values?

-1 (unknown) wasn't written to the entries file. -2 was, but I'm
testing a patch which leaves it out now.

> > + The purpose of this field is to serve as a reference for the
> > + change-detection heuristic used by the 'status' command.
> >
> Woops, status is not the only user of change detection.

Ok, well, I didn't mean for that to be taken than explicit. I added '-
amongst others -'. That enough, or should I just leave off that
addition?

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 16 00:34:11 2007

This is an archived mail posted to the Subversion Dev mailing list.