[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Missing editor->abort_edit() in wc_to_repos_copy() ?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-03-12 16:34:17 CET

Gerco Ballintijn wrote:
> Hi,
>
> I noticed the following. svn_client__do_commit() is called by both
> svn_client_commit4() and wc_to_repos_copy(). svn_client__do_commit()
> ends with editor->close_edit() on success, but no editor->abort_edit()
> on failure. Now, svn_client_commit4() does call editor->abort_edit()
> when svn_client__do_commit() returns unsuccessfully, but as far as I
> can tell wc_to_repos_copy() does not call editor->abort_edit() when
> svn_client__do_commit(). Isn't this a bug?

I would say, "yes, bug." (And I've just independently confirmed that my
reading of the code matches yours, having originally seen only the subject
line of your post.)

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Mon Mar 12 16:34:32 2007

This is an archived mail posted to the Subversion Dev mailing list.