[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Missing editor->abort_edit() in wc_to_repos_copy() ?

From: Gerco Ballintijn <gerco_at_ballintijn.com>
Date: 2007-03-11 12:04:30 CET

Hi,

I noticed the following. svn_client__do_commit() is called by both
svn_client_commit4() and wc_to_repos_copy(). svn_client__do_commit()
ends with editor->close_edit() on success, but no editor->abort_edit()
on failure. Now, svn_client_commit4() does call editor->abort_edit()
when svn_client__do_commit() returns unsuccessfully, but as far as I
can tell wc_to_repos_copy() does not call editor->abort_edit() when
svn_client__do_commit(). Isn't this a bug?

With regards,
Gerco.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 11 12:04:46 2007

This is an archived mail posted to the Subversion Dev mailing list.