[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Can not checkout revisions which author name rev property contains ASCII control characters

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2007-03-04 17:12:17 CET

Erik Huelsmann wrote:
> On 3/1/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
>> On Fri, Feb 09, 2007 at 11:54:04PM +0600, Alexander Sinyushkin wrote:
>> > Hello, SVN devs! I have recently encountered the following problem:
>> > I tried to make a dir in a repository remotely and used an ASCII
>> > control character ('\b' in particular) in my --username switch:
>> >
>> > >svn mkdir file:///G:/materials/rep/test2 --username Sasha
>> >
>> > Committed revision 442.
>> >
>> > svn.exe committed without problems.
>> >
>> > But when I tried to checkout what I had committed I got the following
>> > error:
>> >
>> > >svn co http://localhost/materials/rep/test2 test5 --username garry
>> --password garry
>> > svn: Malformed XML: not well-formed (invalid token) at line 6
>> >
>> > It seems to me that the problem is in this backspace symbol. Is it
>> > expected behaviour that svn.exe crashes attempting to parse the log
>> > file?
>> >
>>
>> No, we should either be preventing the original commit, or (more likely)
>> encoding the string correctly when we write it to the log. I've raised
>> issue 2730 to cover this.
>
> We have a perfectly sane way to serialize internal datastructures in
> our codebase which won't need encodings: ra_svn uses tuples and some
> other data types which nicely fit our in-memory storage model.
> Shouldn't we switch to that instead of fixing our XML
> storing/parsing?
>
> Just a thought.

Ooh, that's a nice idea. IMO, there's even less reason to use XML for
WC-logs than there was for entries files.

Max.

Received on Sun Mar 4 17:12:50 2007

This is an archived mail posted to the Subversion Dev mailing list.