On Feb 28, 2007, at 5:25 PM, C. Michael Pilato wrote:
> C. Michael Pilato wrote:
>> William Nagel wrote:
>>> On Feb 4, 2007, at 2:16 AM, Karl Fogel wrote:
>>>
>>>> A comment on the code: you've made the 'indentation' parameter
>>>> to print_tree() have a new meaning. The doc string for that
>>>> function
>>>> should change to reflect this.
>>> ...
>>>
>>>> Also, please provide a log message with your patch :-).
>>> I fixed the doc string for print_tree, as per your suggestion, and
>>> created a log message.
>>>
>>> A new patch for issue 2663, as well as the log message are attached.
>>
>> There are a couple of minor problems here. First, you managed to
>> introduce
>> a single tab character into the source code (and we don't use tab
>> characters). Secondly, I think we usually use the positive form
>> of the
>> recursion options. So, the parameter would be named 'recurse',
>> and your
>> logic reversed.
>>
>> I'll make these changes myself -- no need to go through another
>> round of this.
>
> Patch committed with the mods I mentioned, plus some others I found
> while
> reviewing. (A missing "break;" statement after the new switch case; a
> slightly off test description, etc.)
>
> Thanks, William.
Awesome! Thanks! Hopefully there will be many more patches to
follow. I'm hoping to get much more involved in SVN development.
-Bill
>
> --
> C. Michael Pilato <cmpilato@collab.net>
> CollabNet <> www.collab.net <> Distributed Development On
> Demand
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 1 01:42:50 2007