[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Behavior check: svnadmin load of revisions with no datestamp

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-02-28 21:37:09 CET

C. Michael Pilato wrote:
> Ben Collins-Sussman wrote:
>> On 2/26/07, C. Michael Pilato <cmpilato@collab.net> wrote:
>>
>>> But I think you misunderstood my question. I am taking for granted
>>> that the
>>> ability to have a missing svn:date is *not* a bug. My question is,
>>> "In such
>>> a case, should a date suddenly appear just because you dump and load the
>>> repository data?" I think not. *That's* the bug I'm talking about.
>> I think you've identified a bug, yeah.
>>
>> In that same vein, what if a revision has no svn:author property?
>> That's far more common (and less havoc-wreaking) than the 'no
>> svn:date' scenario. In that case, might 'svnadmin load' (or even
>> 'svnsync sync') be accidentally creating svn:author properties?
>
> No, a missing author is fine because the filesystem code doesn't assume
> there is an author for every commit. I'm sure that svn:date is a special
> case here because that property is the one property that Subversion creates
> itself at txn-start time, and rewrites itself at txn-commit time.

I've filed this as issue #2729, and will be supplying a fix and test case soon.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Feb 28 21:37:23 2007

This is an archived mail posted to the Subversion Dev mailing list.