[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [merge-tracking] 'svn blame' auditing

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-02-23 00:03:31 CET

On Wed, 21 Feb 2007, Hyrum K. Wright wrote:

> Daniel Rall wrote:
> > Once "how it's supposed to work" is defined, these changes can be
> > implemented incrementally (though, once you've got the functionality
> > for one command, it should be very easy to roll it out to others!).
> >
> >> Before I begin, though. I would like to know if
> ...
> >> b) Anybody has any suggestions/recommendations as to where to begin.
> >
> > Let's start by zeroing in on a really solid definition how this is
> > supposed to work. I'd volunteer to roll that into the func spec,
> > while you're working on implementing it for the 'log' or 'blame'
> > command.
> That would be great!

Today I re-organized the requirements so that they are now (hopefully)
easier to digest. I'll continue to tweak and clarify them as needed.

> I'm also interested in where best this functionality could be placed. I
> tend to think that it should be added to libsvn_repos, to help
> streamline the amount of data going back and forth between client and
> server. My understanding may be incomplete, though.

Yeah, a lot of the logic will live in libsvn_repos. We'll likely need
to add parameters to some of the APIs in there, too, and punch those
API changes through the RA layer back to the client.

> > - Should We provide an API/command-line switch for which names to
> > show, rather than always showing both user names? I tend to think so.
> > How would this (new?) switch interact with --verbose (e.g. for 'log')?
> I think a new switch would be a good idea. If possible, I suggest that
> we invent a switch with a single character shortcut. Such a switch is
> likely to be used by several commands, and it may be used frequently.

Yes. I still curse the fact that the --limit switch to log doesn't
have a single-character shortcut. I use it many times a day!

> >> If all goes well, I hope to be able to start posting patches in the next
> >> couple of weeks.
> >
> > Fantastic, Hyrum!
> Thanks. Note that the time prediction is definitely a lower bound, not
> a guarantee. :)

Of course. :-) I'll be a happy camper if we have the requirements and
func spec nailed down by then.

> Relatedly, where can I find a concrete example of merge info usage, such
> as fetching the merge info and doing something with it?

subversion/libsvn_client/diff.c:do_merge() fetchs merge info does a
ton with it. For simpler examples, see callers of
calculate_target_merge_info() in subversion/libsvn_client/copy.c.

  • application/pgp-signature attachment: stored
Received on Fri Feb 23 00:03:44 2007

This is an archived mail posted to the Subversion Dev mailing list.