[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow clients to check out special files with unknown type

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-02-22 22:36:26 CET

On Tue, Feb 20, 2007 at 04:35:30PM +0100, Peter Lundblad wrote:
> Malcolm Rowe writes:
> > So this is the patch I'm planning to commit, updated based on your
> > review. Any further comments?
> >
> Looks fine to me.

Thanks, r23467.

> > We can cover EPERM handling in an followup commit, if we decide that's
> > appropriate.
> >
> I think it is appropriate, but I agree it should be a separate change.

Looks like I'm going to have to reuse the APR_STATUS_IS_EPERM() macro
that's currently defined in io.c. I could copy it to subst.c, but I'd
prefer to move it into a header file. There doesn't seem to be anywhere
particularly appropriate, so I was thinking include/private/svn_compat.h
- anyone have any objections to that?


  • application/pgp-signature attachment: stored
Received on Thu Feb 22 22:36:47 2007

This is an archived mail posted to the Subversion Dev mailing list.