[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_wc_text_modified_p2?

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2007-02-21 09:22:58 CET

On 2/21/07, Daniel Rall <dlr@collab.net> wrote:
> On Tue, 20 Feb 2007, Peter Lundblad wrote:
>
> > Hi, folks,
> >
> > In r20945, pburba revved the svn_wc_text_modified_p public API to also take
> > an use_tmp_base flag. If that's set, the working file is compared against
> > the temporary text-base file in .svn/tmp/text-base.
> >
> > Are there any plans to use this new functionality outside of libsvn_wc?
> > If not, then I think this new API should be removed and the internal user
> > in libsvn_wc that actually needs this should be converted to use the
> > internal version of this function because:
> > a) it exposes an implementation detail of libsvn_wc which we might
> > want to change in the future
> > b) we shouldn't expose things publically that we (or someone else)
> > don't use outside of the library.
> >
> > Comments?
>
> Moving this to a module-private API visible only to libsvn_wc sounds
> reasonable to me.
>
For me too. It's internal details.

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 21 09:23:10 2007

This is an archived mail posted to the Subversion Dev mailing list.