[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_wc_text_modified_p2?

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-02-20 22:46:15 CET

On Tue, 20 Feb 2007, Peter Lundblad wrote:

> Hi, folks,
>
> In r20945, pburba revved the svn_wc_text_modified_p public API to also take
> an use_tmp_base flag. If that's set, the working file is compared against
> the temporary text-base file in .svn/tmp/text-base.
>
> Are there any plans to use this new functionality outside of libsvn_wc?
> If not, then I think this new API should be removed and the internal user
> in libsvn_wc that actually needs this should be converted to use the
> internal version of this function because:
> a) it exposes an implementation detail of libsvn_wc which we might
> want to change in the future
> b) we shouldn't expose things publically that we (or someone else)
> don't use outside of the library.
>
> Comments?

Moving this to a module-private API visible only to libsvn_wc sounds
reasonable to me.

  • application/pgp-signature attachment: stored
Received on Tue Feb 20 22:46:26 2007

This is an archived mail posted to the Subversion Dev mailing list.