[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking] Reporter api calls should be made in depth first order (Fix and TestCase)

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-02-14 01:01:42 CET

On Tue, 13 Feb 2007, Kamesh Jayachandran wrote:

> Peter Lundblad wrote:
> >Kamesh Jayachandran writes:
...
> >>>>@@ -3513,7 +3514,6 @@
> >>>> return svn_error_createf(SVN_ERR_UNVERSIONED_RESOURCE, NULL,
> >>>> _("'%s' is not under version
> >>>> control"),
> >>>> svn_path_local_style(child_wcpath,
> >>>> pool));
> >>>>-
> >>>> child_repos_path = child_wcpath +
> >>>> strlen(merge_cmd_baton->target) + 1;
> >>>> child_url = svn_path_join(parent_wc_url, child_repos_path, pool);
> >>>>
> >>>Also not changed here, but that added path here won't be URL-encoded,
> >>>right?
> >>
> >>Should we?
> >
> >You are constructing a new URL by concatenating an URL and
> >a working copy path fragment, right? What happens if that fragment
> >contains characters that should be URI escaped?
>
> Will try to make it fail and fix it.

It's definitely a potential problem. Wrap the return value of
svn_path_join() in svn_path_uri_encode().

  • application/pgp-signature attachment: stored
Received on Wed Feb 14 01:02:02 2007

This is an archived mail posted to the Subversion Dev mailing list.