[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cleanup fails on missing .svn/tmp

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-02-06 15:58:05 CET

Malcolm Rowe writes:
> As I understood it, 'svn cleanup' is supposed to fix a particular
> problem (completing aborted in-progress working-copy transactions, and
> in doing so, unlocking the wc); it's not supposed to be a general-purpose
> recovery tool.
>
I agree that cleanup is not a general recovery tool, even though the error
message that Henner showed suggests otherwise. I think that it is good
to recreate the tmp area on cleanup, though, since failed operations
can always leave around temp files that just stay there forever.
And while doing this, it seems silly to not just ignore the case where
.svn/tmp doesn't exist.

If other feel that we shouldn't, then we should at least make the
suggestion in the error message less confusing.

> > If you look at the code, this error occurs while removing the tmp/
> > directory unconditionally to create a fresh version of it. So this
> > code will in any case remove tmp/ whether there are files or not.
>
> I'm not that familiar with the code myself, but I'm surprised that we
> unconditionally remove the contents without checking them first - Erik's
> reply [1] in particular seems to indicate that we'd not want to just
> recreate the directory unconditionally (plus there's the 'something bad
> happened' indicator that I think would be a good idea to retain).
>
> [1] http://svn.haxx.se/dev/archive-2006-07/0283.shtml
>

I don't understand what essential files Erik is referring to.
At cleanup time, the log is first rerun. If that does *not*
result in an error, then the tmp area is removed and rebuilt.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 6 15:58:25 2007

This is an archived mail posted to the Subversion Dev mailing list.