[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cleanup fails on missing .svn/tmp

From: Henner Zeller <h.zeller_at_acm.org>
Date: 2007-02-06 13:44:44 CET

Hi,
> The last time this was brought up, the consensus seemed to be that this
> wasn't something we wanted to attempt to clear up.
>
> (one reason was that you have no way to know whether the tmp/ directory
> actually was empty before it was removed)
>
> See e.g. http://svn.haxx.se/dev/archive-2006-07/0217.shtml and
> surrounding thread.

Well, this thread ends in a half religous discussion about error
checking and if tools should be user friendly, but doesn't really
address the issue.

If you look at the code, this error occurs while removing the tmp/
directory unconditionally to create a fresh version of it. So this
code will in any case remove tmp/ whether there are files or not.
However, this code fails in the first step (removing the tmp/
unconditionally) if the directory doesn't exist (which is exactly the
expected result of this removing). So this shouldn't fail here.
Ignoring the 'error' of this directory not beeing here is the Right
Thing to do.

cheers,
  -henner

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 6 13:44:52 2007

This is an archived mail posted to the Subversion Dev mailing list.