[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23307 - trunk/subversion/svn

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-02-01 16:23:38 CET

Hyrum K. Wright writes:
...
> > SVN_REVNUM_T_FMT was kept as a convenience for external library users.
>
> I agree that we shouldn't be using SVN_REVNUM_T_FMT in places that break gettext.
> The line that Dan pointed out just converts the revision number to a string,
> which is then used elsewhere. There are several places we do this, and I've
> already made the change in r23309. If we still think that we shouldn't use
> SVN_REVNUM_T_FMT in any of these locations, I'll be happy to revert.
>

Yeah, please revert that change again! There's absolutely no point in
using a constant here since the compiler (GCC at least) already checks
the correctness of the format string.

Sorry for the extra work,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 1 16:24:10 2007

This is an archived mail posted to the Subversion Dev mailing list.