[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking]Clarity in function name

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-01-30 15:12:09 CET

Daniel Rall wrote:
> On Thu, 25 Jan 2007, Kamesh Jayachandran wrote:
> ...
>
>> [[[
>>
>> * subversion/libsvn_client/diff.c
>> (discover_and_merge_children_with_merge_info): Renamed from do_child_merges.
>> (svn_client_merge3, svn_client_merge_peg3):
>> Calls discover_and_merge_children_with_merge_info.
>> (do_merge): Remove 'completed' TODO of 'Subtree merge info'.
>>
>> Patch by: kameshj
>> Suggested by: dlr
>> ]]]
>>
>
> Kamesh, this looks fine to me, please commit. The new name is quite
> verbose, but nothing more brief came to mind other than shortening it
> to discover_and_merge_children().
>
> - Dan
>
> p.s. I committed the TODO separately.
>
Committed at r23290.

Thanks,
With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 30 15:11:39 2007

This is an archived mail posted to the Subversion Dev mailing list.