[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_client: Destroy the subpools

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2007-01-22 10:41:55 CET

On Tue, 2007-01-16 at 15:58 -0800, Daniel Rall wrote:
> On Tue, 16 Jan 2007, Bhuvaneswaran Arumugam wrote:
>
> > On Tue, 2007-01-09 at 15:11 +0530, Bhuvaneswaran Arumugam wrote:
> > > Hello,
> > >
> > > This is a follow-up patch for r22933. Please find the attached patch.
> >
> > Any review comment for this?
>
> Looks good to me, +1.

So, shall i commit this one?

> > > [[[
> > > Destroy the APR subpool before every successful return statement.
> > >
> > > [in subversion/libsvn_client/]
> > > * delete.c
> > > (delete_urls):
> > > * repos_diff.c
> > > (svn_client__get_diff_editor):
> > > * externals.c
> > > (switch_external):
> > > * list.c
> > > (get_dir_contents):
> > > Destroy the APR subpool before returning successfully to prevent
> > > iterative pool creation.
> > >
> > > Patch by: bhuvan
> > > ]]]
>
> I wish the log message could be more compact, though I'm not sure
> exactly how I'd change it.

If someone can make this better, thats fine.

-- 
Regards,
Bhuvaneswaran

Received on Mon Jan 22 10:42:35 2007

This is an archived mail posted to the Subversion Dev mailing list.