[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_client: Destroy the subpools

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-17 00:58:25 CET

On Tue, 16 Jan 2007, Bhuvaneswaran Arumugam wrote:

> On Tue, 2007-01-09 at 15:11 +0530, Bhuvaneswaran Arumugam wrote:
> > Hello,
> >
> > This is a follow-up patch for r22933. Please find the attached patch.
>
> Any review comment for this?

Looks good to me, +1.

> > [[[
> > Destroy the APR subpool before every successful return statement.
> >
> > [in subversion/libsvn_client/]
> > * delete.c
> > (delete_urls):
> > * repos_diff.c
> > (svn_client__get_diff_editor):
> > * externals.c
> > (switch_external):
> > * list.c
> > (get_dir_contents):
> > Destroy the APR subpool before returning successfully to prevent
> > iterative pool creation.
> >
> > Patch by: bhuvan
> > ]]]

I wish the log message could be more compact, though I'm not sure
exactly how I'd change it.

  • application/pgp-signature attachment: stored
Received on Wed Jan 17 00:58:31 2007

This is an archived mail posted to the Subversion Dev mailing list.