[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23056 - in branches/perl-bindings-improvements: . subversion/bindings/swig/perl/native

From: John Peacock <jpeacock_at_rowman.com>
Date: 2007-01-17 17:44:39 CET

David Glasser wrote:
> On 1/16/07, jpeacock@tigris.org <jpeacock@tigris.org> wrote:
>> Log:
>> r22621@jfphome: jpeacock | 2007-01-16 21:09:45 -0500
>
> I think it might be better to push to the repository with svk's
> --verbatim to avoid this line in the log messages.

Agreed. That was my first "push" to the repository, so I'll know better
next time. Do you think it is worthwhile revising the log entry?

>> +I have not tested this functionality (and I am not sure how to do
>> so), but
>> +you must at least provide undef for these parameters for the method call
>> +to work.
>
> The "I have not tested" and "you must provide at least" wording is a
> little odd; I'd recommend testing it (throw in a function that returns
> true on the third call or something) so you can remove that, and
> documenting it as "If you do not care about allowing the user to
> cleanly cancel this operation, pass undef for these arguments
> instead."

Since this is on a branch, I first wanted to commit the patches as is
(to provide history), then go through and clean up both the
documentation and add tests. Danial Rall has been kind enough to
sponsor a branch for Nik Clayton and myself to bang on the Perl
bindings. I hope that you can keep an eye on what we are doing, so we
don't wander too far off the path... ;-)

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 17 17:44:49 2007

This is an archived mail posted to the Subversion Dev mailing list.