Re: svn commit: r23056 - in branches/perl-bindings-improvements: . subversion/bindings/swig/perl/native

On 1/16/07, jpeacock@tigris.org <jpeacock@tigris.org> wrote:
> Author: jpeacock
> Date: Tue Jan 16 18:32:21 2007
> New Revision: 23056
>
> Log:
> r22621@jfphome: jpeacock | 2007-01-16 21:09:45 -0500

I think it might be better to push to the repository with svk's
--verbatim to avoid this line in the log messages.

> +According to svn_repos.h, the C<$cancel_func> is a function that is called
> +periodically and given C<$cancel_baton> as a parameter to determine whether the
> +client wishes to cancel the dump. I have not tested this functionality, but
> +you must supply C<undef> at the very least.
[...]
> +I have not tested this functionality (and I am not sure how to do so), but
> +you must at least provide undef for these parameters for the method call
> +to work.

The "I have not tested" and "you must provide at least" wording is a
little odd; I'd recommend testing it (throw in a function that returns
true on the third call or something) so you can remove that, and
documenting it as "If you do not care about allowing the user to
cleanly cancel this operation, pass undef for these arguments
instead."

Thanks for getting around to dealing with these patches! As a
perl-bindings-using full committer I've been meaning to find time to
do so, but am very busy with school. This branch is very appreciated!

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org