[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: File permissions problems with 1.4.0 (yet again!)

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-01-16 17:36:11 CET

Miller, Eric wrote:
> Ok, here is the bug:
>
> io.c is missing #include <errno.h> at line 26.
>
> This is causing EPERM to be undefined, making APR_STATUS_IS_EPERM always
> return 0 thus io_set_file_perms() is never called.
>
> Once errno.h is included the reown functionality behaves like it used
> to.
> Too late for 1.4.3??

I'm totally not following this thread, so forgive me if I'm adding
nothing but noise to it. But glancing at the code, I'm wondering if the
correct fix is *not* to add

   #include <errno.h>

to io.c, but instead to simply move the #ifndef APR_STATUS_IS_EPERM
block to *after* the inclusion of the APR headers. Most of the APR
headers already include apr_errno.h, which includes errno.h on platforms
that have it.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Tue Jan 16 17:56:41 2007

This is an archived mail posted to the Subversion Dev mailing list.