[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: File permissions problems with 1.4.0 (yet again!)

From: Miller, Eric <Eric.Miller_at_amd.com>
Date: 2007-01-12 23:57:35 CET

Ok, here is the bug:

io.c is missing #include <errno.h> at line 26.

This is causing EPERM to be undefined, making APR_STATUS_IS_EPERM always
return 0 thus io_set_file_perms() is never called.

Once errno.h is included the reown functionality behaves like it used
to.
Too late for 1.4.3??

Eric

> -----Original Message-----
> From: Miller, Eric [mailto:Eric.Miller@amd.com]
> Sent: Friday, January 12, 2007 11:16 AM
> To: D.J. Heap
> Cc: Bakke, Steven; users@subversion.tigris.org;
dev@subversion.tigris.org
> Subject: RE: File permissions problems with 1.4.0 (yet again!)
>
> DJ-
>
> Yep, you are right. Let me dive into this a bit more.
> Damn inverse logic bites me again!
>
> Eric
>
> > -----Original Message-----
> > From: D.J. Heap [mailto:djheap@gmail.com]
> > Sent: Friday, January 12, 2007 11:14 AM
> > To: Miller, Eric
> > Cc: Bakke, Steven; users@subversion.tigris.org;
> dev@subversion.tigris.org
> > Subject: Re: File permissions problems with 1.4.0 (yet again!)
> >
> > On 1/12/07, Miller, Eric <Eric.Miller@amd.com> wrote:
> > > Ok, here is the issue I think.
> > >
> > > In 1.3.2 there was a function called
> > > svn_io_set_file_read_write_carefully() that called the reown
> subroutine
> > if needed. Reown does exactly what I did below :) Reown works for
a
> > multi-user (common group) working copy use case as we saw in the
past.
> > >
> > > 1.4.* removed the _carefully function and added a new set of
> permission
> > functions, one of which is svn_io_set_file_read_write(). This
> function
> > calls io_set_file_perms() which uses reown - BUT ONLY FOR Win32.
> >
> >
> >
> > Are you sure? It looks like the opposite to me.
> >
> > DJ
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 13 00:04:24 2007

This is an archived mail posted to the Subversion Dev mailing list.