[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should this test pass?

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: 2007-01-11 16:41:13 CET

Hi Vlad and Brane,

On 1/11/07, Branko ╚ibej <brane@xbc.nu> wrote:
> Joe Swatosh wrote:
> > Hi Daniel,
> >
> > On 1/10/07, Daniel Rall <dlr@collab.net> wrote:
> >> On Wed, 10 Jan 2007, Joe Swatosh wrote:
> >>
> >> > ... Its interesting that the original
> >> > Ruby bindings tests pass on kou's platform.
> >>
> >> If he was running them only under FSFS, it wouldn't have had this
> >> problem,
> >> yes?
> >>
> > True. The first way I got the Ruby binding tests in question to
> > "pass" was to change the file system. But what is going on?
>
> Vlad pretty much answered that.

Yes, thanks.

>
> > Is this a bad test?
>
> Yes. You shouldn't try to delete an open FS.
>
> > Should the test be changed to use FSFS and forget about it?
>
> No. All tests should pass on all filesystems.
>
> > Should the bindings be modified so that this test can pass?
>
> Dunno what the bindings do, but closing the filesystem isn't a bindings
> issue, IMHO -- it's a usage issue.
>

That's pretty much where I ended up, too. If it isn't something to be
encouraged, it shouldn't be in the tests. I'm going to refer kou to
this thread and see how he would like to approach it.

Thanks again,

--
Joe Swatosh
Received on Thu Jan 11 23:16:34 2007

This is an archived mail posted to the Subversion Dev mailing list.