[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should this test pass?

From: Vlad Georgescu <vgeorgescu_at_gmail.com>
Date: 2007-01-11 08:57:27 CET

On 1/11/07, Daniel Rall <dlr@collab.net> wrote:
> On Wed, 10 Jan 2007, Joe Swatosh wrote:
>
> > ... Its interesting that the original
> > Ruby bindings tests pass on kou's platform.
>
> If he was running them only under FSFS, it wouldn't have had this problem,
> yes?

I think the BDB problem is specific to Windows. On Unix, when you
delete an opened file, the directory entry is removed immediately, and
the disk space is freed when the file is closed, so the call to
svn_io_remove_dir completes successfully. Windows normally doesn't
allow you to delete an opened file, except when the FILE_SHARE_DELETE
flag is passed to CreateFile (which is how BDB creates its tables,
apparently). In that case, the file is marked for deletion but the
directory entry isn't removed until the file is closed. So
svn_io_remove_dir happily "deletes" all files, but then it rewinds the
dir (to work around broken readdir() implementations on
MacOSX/FreeBSD) and tries to delete the same files again, which now
fails.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 11 08:57:38 2007

This is an archived mail posted to the Subversion Dev mailing list.