[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r22727 dead code (Coverity CID 47)

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-01-09 00:45:12 CET

On 1/5/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> Hi Erik,
> r22727 adjusted svn_wc_transmit_text_deltas2() to remove the only
> non-NULL assignment to the entry_digest_hex local variable, but retained
> optional validation of that (now always NULL) entry checksum against the
> calculated checksum.
> I _think_ that the whole section starting "Make sure the old text base
> still matches its checksum" can now be removed (along with the
> entry_digest_hex variable) because it seems to be covered by the code
> above added in that revision, but I'm not familiar enough with the code
> to know for sure.
> [This is Coverity CID 47, by the way].
> Also, while we're there, you also (in the same revision) removed the
> localfile local variable but _added_ a commented-out svn_io_file_close()
> call with that variable (after the comment "Close the two files");
> I'm assuming that's just cruft?

I agree on both counts. The patch was very old and I had to do a lot
of integrating. Thanks for finding these issues.




To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 9 00:45:21 2007

This is an archived mail posted to the Subversion Dev mailing list.