[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

r22727 dead code (Coverity CID 47)

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-01-05 13:41:28 CET

Hi Erik,

r22727 adjusted svn_wc_transmit_text_deltas2() to remove the only
non-NULL assignment to the entry_digest_hex local variable, but retained
optional validation of that (now always NULL) entry checksum against the
calculated checksum.

I _think_ that the whole section starting "Make sure the old text base
still matches its checksum" can now be removed (along with the
entry_digest_hex variable) because it seems to be covered by the code
above added in that revision, but I'm not familiar enough with the code
to know for sure.

[This is Coverity CID 47, by the way].

Also, while we're there, you also (in the same revision) removed the
localfile local variable but _added_ a commented-out svn_io_file_close()
call with that variable (after the comment "Close the two files");
I'm assuming that's just cruft?


  • application/pgp-signature attachment: stored
Received on Fri Jan 5 13:41:41 2007

This is an archived mail posted to the Subversion Dev mailing list.