On 12/28/06, Kouhei Sutou <kou@cozmixng.org> wrote:
> "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
>
> > Most failures occur at svn/util.rb:68 where a Proc for a forwarding function is
> > created. I tried "puts" of the target_method before the "call," but that moved
> > the SegFault around too. It often claimed to be svn_utf_cstring_to_utf8, but I
> > couldn't figure out how we were getting there from any of the test code.
>
> Ah, OK. I'll think about another more debug friendly
> mechanism.
>
Great.
This is the thing that is bugging me most. I hate that the tests
aren't running. I hope someone else who is interested in getting
these bindings built for Windows jumps in and helps us out.
> > The test code modifications create a dependency on win32-service which is part
> > of Win32Utils on RubyForge (http://rubyforge.org/projects/win32utils/) or as a
> > gem.
>
> I agree with the idea but I think Win32 service setup should
> be done in SvnTestUtil#setup_svnserve not run-test.rb. So I
> will change run-test.rb like the following. What about this?
>
The patch looks good (eyeballs only, I haven't tried it yet). While I
find the notion of keeping all the Windows service related stuff in a
single file appealling, I'm not sure I like the idea of creating and
destroying the Windows Service for every test. Perhaps we could move
the creation of the Service to when util.rb is loaded, then remove the
service at_exit? That way we'd only have to start and stop the
service for each test?
I happened to have the win32-service gem installed on my system, so I
used it. However, I think we should consider carefully whether or not
we want to create a dependency on it. The code would be a good deal
uglier, but what we are using it for could be accomplished by shelling
out to the "sc" and "net start|stop" commands.
>
> > * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> I've merged.
Yay.
>
> > * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.h
> > When building with VC compiler use the #pragma comment directive to link with
> > the ruby library.
>
> I'll talk about this in the next mail.
>
I think we're getting close on that one.
> > * subversion/bindings/swig/ruby/test/util.rb
> > Start and stop the Service, without using fork. Fix typo in URI?
>
> We need to talk about them.
>
> 'file' schema URI isn't a typo.
>
Looking at http://svnbook.red-bean.com/nightly/en/svn.advanced.reposurls.html
make me think that it should either include a node name or a third
slash, but truely I am no expert.
Thanks for letting me help out a little.
-Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 29 20:55:21 2006