[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Linking the Ruby bindings on windows

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: 2006-12-29 17:24:34 CET

On 12/28/06, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> In <ae6cb1100612281744k73fc573h7b631d2588a21056@mail.gmail.com>
> "[PATCH] Linking the Ruby bindings on windows" on Thu, 28 Dec 2006 17:44:37 -0800,
> "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
>
> > The latest commits from kou do indeed cause the libsvn_swig_ruby to
> > compile with VC6 and SWIG 1.3.24. Unfortunately, the change committed
> > to build.conf doesn't appear to be sufficent to allow the bindings to
> > link.
>
> OK. I didn't understand the build system on Windows. I
> thought build.conf is used on Windows too. Sorry.
>

I don't really understand it either. Like I said, I was just
mimicking the way it was handled for Perl.

> > + def _find_ruby(self):
> > + "Find the right Ruby library name to link swig bindings with"
> > + fp = os.popen('ruby -e ' + escape_shell_arg(
> > + 'print Config.expand(Config::CONFIG[\'LIBRUBY\'])'), 'r')
>
> I think Config.expand isn't needed:
> fp = os.popen('ruby -e ' + escape_shell_arg(
> 'print Config::CONFIG["LIBRUBY"]'), 'r')
>
> '-r rbconfig' isn't needed on Windows?
>

You're right the Config.expand isn't needed (I started with
Config::MAKEFILE_CONFIG which did need it). I haven't needed to
require rbconfig, but it is probably a good idea.

Joe Swatosh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 29 17:24:41 2006

This is an archived mail posted to the Subversion Dev mailing list.