Re: [PATCH] Linking the Ruby bindings on windows

Hi,

In <ae6cb1100612281744k73fc573h7b631d2588a21056@mail.gmail.com>
  "[PATCH] Linking the Ruby bindings on windows" on Thu, 28 Dec 2006 17:44:37 -0800,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> The latest commits from kou do indeed cause the libsvn_swig_ruby to
> compile with VC6 and SWIG 1.3.24. Unfortunately, the change committed
> to build.conf doesn't appear to be sufficent to allow the bindings to
> link.

OK. I didn't understand the build system on Windows. I
thought build.conf is used on Windows too. Sorry.

> Generate project files for VC6 that will link the Ruby bindings with
> the Ruby library.
>
> * build/generator/gen_win.py
> Mimicked the way that Perl was determining what lib to link with when
> building the bindings.

I want to commit this changes. Do I have authority to commit
into this area? Or does anyone review and vote this changes?

> + def _find_ruby(self):
> + "Find the right Ruby library name to link swig bindings with"
> + fp = os.popen('ruby -e ' + escape_shell_arg(
> + 'print Config.expand(Config::CONFIG[\'LIBRUBY\'])'), 'r')

I think Config.expand isn't needed:
    fp = os.popen('ruby -e ' + escape_shell_arg(
                  'print Config::CONFIG["LIBRUBY"]'), 'r')

'-r rbconfig' isn't needed on Windows?

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org