Hyrum K. Wright wrote:
> Lars Müller wrote:
>> On Wed, Dec 06, 2006 at 10:40:33AM -0500, C. Michael Pilato wrote:
>>> I would recommend now that we add a command-line option for forcing
>>> stdout mode. And then I would recommend one of two followup actions:
>>>
>>> * Either deprecate the -l option now that folks can use
>>> commit-email.pl --stdout >> logfile (and get mbox format!)
>>>
>>> * Or at least make the -l option add the mbox From header.
>> Attached as diff a version based on rev 22589 with a --stdout command
>> line option. I reverted all former and not superfluous changes made
>> with rev 22589.
>>
>> Your second suggestion is already the case as the -l option uses the
>> same @head as stdout does.
>>
>> By intention I did not remove the -l option. This is up to one of the
>> subversion committers.
>>
>> Might some users use -l to pass the message to a file and afterwards
>> perform modifications on this file? If this is the case it might be
>> usefull to stay with -l further. Yes, these users might even pipe the
>> output to their modifying commands or redirect the output to a file.
>> The only potential problem I see is after an update to a newer
>> subversion version. A missing -l option might then break existing
>> scripts.
>>
>> While testing I ran into the problem of a non valid mbox output as soon
>> as the locale is set to something non US or non POSIX. The problem is
>> the first line of the output. I first thought about circumventing this
>> by setting the locale to POSIX while output the particular line. But we
>> might consider to document this problem instead.
>
> Ping...
>
> Has anybody looked at this part of Lars' patch? If nothing happens,
> I'll file an issue in a few days.
>
> -Hyrum
Hyrum, if you file this in the issue tracker, please add me as a Cc: on
the issue. If no one gets around to it before, I'll try to review this,
but can't do so right now for lack of time. Thanks.
--
C. Michael Pilato <cmpilato@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Fri Dec 29 04:02:05 2006