[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22818 - trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-12-28 07:09:05 CET

Hi,

2006/12/28, Madan U S <madan@collab.net>:

> > Log:
> > Use SIZEOF_LONG_LONG instead of sizeof(long long).
>
> Please mention macro'ing of AI642NUM too in the above log summary.

OK. I did.

> > +#if SIZEOF_LONG_LONG == 8
>
> The current equivalent of this comparison is:
> sizeof(apr_int64_t) == sizeof(long long)
>
> You have hardcoded 8 instead of apr_int64_t. Is this intentional? Why? If so, I think you should make a note of it in the log.

apr_int64_t's size must be 64bits and 64bits is 8bytes.
I think sizeof(apr_int64_t) == 8 is clear. Should I add a note?

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 28 07:09:12 2006

This is an archived mail posted to the Subversion Dev mailing list.