[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_dav && out-of-memory in Neon

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-11 18:29:10 CET

On Sun, 10 Dec 2006, Erik Huelsmann wrote:

> Working on the ra_dav-refactoring branch, I noticed that sometimes
> succesfull creation of Neon resources is explicitly checked: Most of
> the time, for example, is the return value from ne_request_create()
> checked for non-nullity.
> Checking the neon sources, all Neon ever does in its constructors is
> allocate memory and initialize it. When we fail to allocate memory in
> our libraries, we just abort().
> I'd like to replace these explicit checks (and the subsequent -memory
> allocating- creation of an error) with abort calls in the functions we
> wrapped around these Neon constructors. Especially since at other
> times, we don't check for nullity at all (for example when creating
> lock structures...).
> So, anybody with objections?

Nope, this sounds good, especially if it's consistent with
Subversion's usual pattern.

  • application/pgp-signature attachment: stored
Received on Mon Dec 11 18:23:08 2006

This is an archived mail posted to the Subversion Dev mailing list.