[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

ra_dav && out-of-memory in Neon

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-12-10 23:13:23 CET

Working on the ra_dav-refactoring branch, I noticed that sometimes
succesfull creation of Neon resources is explicitly checked: Most of
the time, for example, is the return value from ne_request_create()
checked for non-nullity.

Checking the neon sources, all Neon ever does in its constructors is
allocate memory and initialize it. When we fail to allocate memory in
our libraries, we just abort().

I'd like to replace these explicit checks (and the subsequent -memory
allocating- creation of an error) with abort calls in the functions we
wrapped around these Neon constructors. Especially since at other
times, we don't check for nullity at all (for example when creating
lock structures...).

So, anybody with objections?

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 10 23:13:39 2006

This is an archived mail posted to the Subversion Dev mailing list.