[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22599 - in branches/multiple-moves/subversion: include libsvn_client svn

From: David Glasser <glasser_at_mit.edu>
Date: 2006-12-07 20:58:06 CET

On 12/7/06, hwright@tigris.org <hwright@tigris.org> wrote:
> On the multiple moves branch:
> Merge the svn_client_[copy,move] and svn_client_[copy,move]_into APIs. The
> idea of the new APIs is to Do The Right Thing when given a list of source paths
> and a destination path. The new APIs also have a flag to preserve compatibility
> with the changes introduced in r18315 to fix issue 2188.

The more I think about it, the more it seems like two separate APIs is
better than one API with a boolean that entirely changes its
semantics. For example, I found the documentation for the separated
_into function easier to understand than the documentation for the
combined function. (I'm still not sure what the combined API should
do if you pass a multiple-element array but set copy_as_child to
FALSE.) (Also, in the common case of a single-file-copy/move, this
requires extra code to create an array.)


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 7 20:58:25 2006

This is an archived mail posted to the Subversion Dev mailing list.