On 12/7/06, Mark Phippard <markphip@gmail.com> wrote:
>
> On 12/6/06, Daniel Rall <dlr@collab.net> wrote:
>
> > On Wed, 22 Nov 2006, Mark Phippard wrote:
> >
> > > Daniel Rall wrote:
> > > >On Tue, 21 Nov 2006, Mark Phippard wrote:
> > ...
> > > >>Since you are doing some stuff with JavaHL lately, one to add to
> > your
> > > >>to-do list would be some kind of support for the svn diff
> > --summarize
> > > >>option. I think this is something we could use in Subclipse to
> > improve
> > > >>performance when comparing two tags of a large project.
> > ...
> > > ... it would return an array of the items that have been modified,
> > > or maybe it would send notifications that would have to be trapped.
> > > Either way, it would be something really different from what diff
> > > does now.
> > >
> > > Ideally, I'd probably like the API to return an array of some sort of
> > Java
> > > objects that describe the item and the type of change etc.
> >
> > Mark, I've written the code for the diff summarize JavaHL bindings:
> >
> > http://svn.collab.net/repos/svn/branches/javahl-diff-summarize
> >
> > When you have a moment, I'd appreciate review of at least the Java
> > APIs. The JUnit test case in BasicTests.java shows how to use it, and
> > return all diff summaries in a list.
> >
> > Unfortunately, there's a bug hiding somewhere in my implementation
> > which I haven't been able to shake out. The bug is triggering an
> > exception (in native code, I think), which subsequently causes a JVM
> > segfault when JavaHL's error handling code calls the
> > env->DescribeException() JNI routine to output a stack trace for the
> > exception. I've spent quite a bit of time on this bug, and could
> > really use some extra eyes.
>
>
> I had a little trouble getting a diff for this since you made the branch
> and commit in one step. Just an fyi.. I had to resort to the commit email
> and eventually just checked it out.
>
> Is there a reason that DiffSummary extends EventObject? I do not know
> what that class is and cannot see any precedent for extending it in JavaHL.
>
> I'll keep digging though.
>
I see that the Notify stuff uses the same technique, so just ignore this
comment. I'll keep looking.
Mark
Received on Thu Dec 7 20:46:41 2006