Re: [PATCH] Perl editor thunk blows stack

On Sat, Nov 18, 2006 at 01:14:28PM -0800, Daniel L. Rall wrote:
> On Sat, 18 Nov 2006, Chia-liang Kao wrote:
>
> > Geoff Richards <qef <at> ungwe.org> writes:
> > > This is reproducible, but not easily, hence no tests. I'm not
> > > sure how I'd go about writing them anyway, and I haven't got the
> > > time right now.
> >
> > Committed, thanks. I am very surprised this hasn't been caught
> > until now.
>
> Should r22332 be backported to the 1.4.x line, then?

Absolutely.

> > > The patch makes my code work, and the tests still work too. The
> > > stack still seems to be getting bigger where it shouldn't, but not
> > > as much. Either I'm misinterpretting that or there's another bug
> > > somewhere else, but this fix definitely makes things better.
> >
> > Can you see where the stack was extended? anywhere other than the
> > xpush's in the thunk caller?

I can't see anything else that would extend the stack, but I haven't
got time to look at it properly right now. I keep meaning to do some
work on the test suite to flush out any other bugs, but it may be a
while until I get round to it.

-- 
--- Geoff Richards -------------><-------------- http://ungwe.org/ ---
"I tried to fling my shadow at the moon,
 The while my blood leapt with a wordless song."  --  Theodore Roethke
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org