[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Perl editor thunk blows stack

From: Daniel L. Rall <dlr_at_finemaltcoding.com>
Date: 2006-11-18 22:14:28 CET

On Sat, 18 Nov 2006, Chia-liang Kao wrote:

> Geoff Richards <qef <at> ungwe.org> writes:
> > This is reproducible, but not easily, hence no tests. I'm not sure how
> > I'd go about writing them anyway, and I haven't got the time right now.
>
> Committed, thanks. I am very surprised this hasn't been caught until now.

Should r22332 be backported to the 1.4.x line, then?

> > The patch makes my code work, and the tests still work too. The stack
> > still seems to be getting bigger where it shouldn't, but not as much.
> > Either I'm misinterpretting that or there's another bug somewhere else,
> > but this fix definitely makes things better.
>
> Can you see where the stack was extended? anywhere other than the xpush's
> in the thunk caller?

  • application/pgp-signature attachment: stored
Received on Sat Nov 18 22:16:04 2006

This is an archived mail posted to the Subversion Dev mailing list.