[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 747: Moving (and copying) multiple files

From: David Glasser <glasser_at_mit.edu>
Date: 2006-11-19 08:19:22 CET

On 11/18/06, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
> Issue 747 succinctly states:
> 'svn mv *.c somedir' does not work. It should.
> Over the past few months, I've been working on a patch which will allow
> just that. Instead of the na´ve approach, which previous patches have
> attempted (looping in the command line client), my approach introduces a
> new client-level API (svn_client_[copy,move]_into) and uses that to fold
> multiple moves into the same commit. It supports both version of move,
> repo->repo and wc->wc, as well as all four directions methods of
> multiple copy, repo->repo, repo->wc, wc->repo and wc->wc. I've also
> added additional tests for this functionality and the patch passes all
> existing tests.

Hyrum, if nothing else, I want to say that it's great that you're
working on this, because this is a seriously annoying deficiency which
as you've seen is a reasonable amount of work to fix. Thanks!

> The one uncertainty I have is how to submit it. The patch is almost 70
> kB and close to 2000 lines long. I'm happy to break it into chunks, but
> I would like to know if there is a preferred way to break something like
> this up. Should I introduce new APIs, and then introduce changes to the
> client which use them? Should I change the client, stub out the new
> APIs and then submit the new functionality?

Probably other people have more wisdom here; I think sending the
single massive patch (or uploading it to the issue, as it is big) is a
reasonable start, though you're probably right that breaking it up for
review and smaller commits may be the way to go eventually. But I'd
rather there be a massive patch on the issue tracker than have it
vanish if you don't find the time to break it up soon.


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 19 08:19:35 2006

This is an archived mail posted to the Subversion Dev mailing list.