[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Issue 747: Moving (and copying) multiple files

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2006-11-19 06:18:57 CET

Issue 747 succinctly states:
'svn mv *.c somedir' does not work. It should.

Over the past few months, I've been working on a patch which will allow
just that. Instead of the na´ve approach, which previous patches have
attempted (looping in the command line client), my approach introduces a
new client-level API (svn_client_[copy,move]_into) and uses that to fold
multiple moves into the same commit. It supports both version of move,
repo->repo and wc->wc, as well as all four directions methods of
multiple copy, repo->repo, repo->wc, wc->repo and wc->wc. I've also
added additional tests for this functionality and the patch passes all
existing tests.

The one uncertainty I have is how to submit it. The patch is almost 70
kB and close to 2000 lines long. I'm happy to break it into chunks, but
I would like to know if there is a preferred way to break something like
this up. Should I introduce new APIs, and then introduce changes to the
client which use them? Should I change the client, stub out the new
APIs and then submit the new functionality?

No doubt there will be some review on the patches as they come in, and I
am sure they can be optimized in places, but I just wanted give people a
heads up that they are coming.


Received on Sun Nov 19 06:19:17 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.