[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash in 1.4.2 and https

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-11-15 18:01:54 CET

Ben Collins-Sussman wrote:
> On 11/13/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
>
>> What would happen if neon tries different auth methods while increasing
>> the 'attempt' value each time? Would that maybe cause this kind of
>> crash? Because as I understand, Subversion only calls
>> svn_auth_first_credentials() if 'attempt' is zero, but it should call
>> this for every 'new' auth method. I could be wrong here of course.]
>
> I'm a bit confused here. It sounds like you're saying that both neon
> and the subversion libraries each have independent, parallel
> implementations of 'trying multiple auth methods'. If so, yes, that
> can lead to bad things.
>
> The design of subversion's libraries is such that different auth
> methods are encapsulated in 'provider' vtables, and then when the RA
> layer calls first_creds(), next_creds(), etc.... the different
> providers are automatically attempted.
>
> But, if neon has its *own* concept of trying multiple auth methods,
> then yeah, that could result in some weird mis-use of svn_auth.h. I
> don't remember that being the case, though...

I've now spent several hours trying to reproduce the problem but was not
successful. Seems I still have something on my setup that isn't the way
it has to be to get the crash.

But I've compared neon 0.25.5 with 0.26.2. And I think I found why it
crashes. As I mentioned before, I suspect that neon counts the auth
attempts over *all* auth methods, while subversion does that per-auth
method.

And by comparing ne_auth.c in 0.25.5 and 0.26.2 I found that neon 0.26.2
indeed has the 'attempt' stored in the auth_request struct, while neon
0.25.5 has it stored in the auth_session struct.

Anyone here who can reproduce the crash and fix this? I hope I could at
least help with finding the reason for the crash.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 15 18:02:25 2006

This is an archived mail posted to the Subversion Dev mailing list.