[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash in 1.4.2 and https

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2006-11-13 23:04:06 CET

On 11/13/06, Stefan Küng <tortoisesvn@gmail.com> wrote:

> What would happen if neon tries different auth methods while increasing
> the 'attempt' value each time? Would that maybe cause this kind of
> crash? Because as I understand, Subversion only calls
> svn_auth_first_credentials() if 'attempt' is zero, but it should call
> this for every 'new' auth method. I could be wrong here of course.]

I'm a bit confused here. It sounds like you're saying that both neon
and the subversion libraries each have independent, parallel
implementations of 'trying multiple auth methods'. If so, yes, that
can lead to bad things.

The design of subversion's libraries is such that different auth
methods are encapsulated in 'provider' vtables, and then when the RA
layer calls first_creds(), next_creds(), etc.... the different
providers are automatically attempted.

But, if neon has its *own* concept of trying multiple auth methods,
then yeah, that could result in some weird mis-use of svn_auth.h. I
don't remember that being the case, though...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 13 23:04:26 2006

This is an archived mail posted to the Subversion Dev mailing list.