[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash in 1.4.2 and https

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-11-13 20:26:05 CET

Stefan Küng wrote:
> C. Michael Pilato wrote:
>> Ben Collins-Sussman wrote:
>>> I can't help with debugging the SSPI scenario, but perhaps we should
>>> patch next_credentials() to check that (iter_baton != NULL), and throw
>>> a real svn_error_t if it is.
>>
>> Nope, an abort() is exactly what we want here. This isn't a user-level
>> problem, it's an API misuse. We have aborts and asserts and good ol'
>> crashes for exactly this scenario.
>
> While I don't object against an assert, I really have to object against
> using an abort(). You can use that for console applications which are
> single threaded. But for UI apps which usually have multiple threads,
> that only leads to a crash which is hard to debug because the crash
> happens somewhere completely unrelated to where the abort() is.

I misspoke -- assert() is absolutely right. (I was trying to speak
generally about the desire to die-horribly-on-invalid-input, and should
have been more careful with my terminology.)

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Mon Nov 13 20:26:26 2006

This is an archived mail posted to the Subversion Dev mailing list.