[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash in 1.4.2 and https

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-11-13 18:43:45 CET

C. Michael Pilato wrote:
> Ben Collins-Sussman wrote:
>> I can't help with debugging the SSPI scenario, but perhaps we should
>> patch next_credentials() to check that (iter_baton != NULL), and throw
>> a real svn_error_t if it is.
>
> Nope, an abort() is exactly what we want here. This isn't a user-level
> problem, it's an API misuse. We have aborts and asserts and good ol'
> crashes for exactly this scenario.

While I don't object against an assert, I really have to object against
using an abort(). You can use that for console applications which are
single threaded. But for UI apps which usually have multiple threads,
that only leads to a crash which is hard to debug because the crash
happens somewhere completely unrelated to where the abort() is.

I just tried to reproduce the crash here with my test setup (since I
have to use a different account and restart my server to boot another
OS, this always takes a lot of time). Unfortunately, I couldn't
reproduce this. So I can't provide much more information than the stack
trace I already sent.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 13 18:44:11 2006

This is an archived mail posted to the Subversion Dev mailing list.