[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add minimum version check to mailer.py

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-10-23 20:15:48 CEST

On Thu, 19 Oct 2006 06:09:10 +0530, C. Michael Pilato
<cmpilato@collab.net> wrote:

> C. Michael Pilato wrote:
>> Daniel Rall wrote:
>>> On Wed, 18 Oct 2006, C. Michael Pilato wrote:
>>>
>>>> Here's a quicky take on what I was thinking in terms of making
>>>> mailer.py
>>>> verify that it is being used with a new enough version of the
>>>> Subversion
>>>> Python bindings. It's basically the same kind of thing I put into
>>>> ViewVC.
>>> I like this idea. Does the 1.5.0 mailer.py really have the Subversion
>>> 1.5.0 Python bindings as a dependency, though? If it doesn't, it
>>> would be better to use the correct minimum version, to allow users to
>>> mix the latest mailer.py with an older version of Subversion.
>>
>> Yes. mailer.py on trunk makes use of the new 'action' code (and other
>> things) added post-1.4.0.
>>
>
> By the way, I committed this in r22031.

Sorry about the late response. Just catching up on mails.

Mike, the import error message is misleading. Wont it be better to say on
the try...except block, something like... "Unable to find subversion
bindings".

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 23 19:46:41 2006

This is an archived mail posted to the Subversion Dev mailing list.