[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improve mingw support

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2006-10-18 02:44:11 CEST

Garrett Rooney wrote:
> On 7/15/06, Paul Querna <chip@force-elite.com> wrote:
>
>> Improve the ability to compile under mingw32.
>>
>> * libsvn_subr/cmdline.c,
>> include/svn_client.h,
>> libsvn_subr/simple_providers.c,
>> libsvn_client/compat_providers.c: Remove support for the windows
>> specific CryptProtectData for authentication. Mingw doesn't
>> include
>> the definitions for this in their headers.
>>
>> * libsvn_subr/config_win.c: Define the minimum IE version to 5.0, since
>> mingw32 doesn't seem to define this.
>>
>
> I committed a chunk of this (turning off the auth provider)

That's ... *bad*

It's more important to encrypt the passwords than to be able to compile
with MinGW, so -1.

Instead, you could declare CopyProtectData in svn_private_config.hw
#ifdef __MINGW32__.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 18 02:45:38 2006

This is an archived mail posted to the Subversion Dev mailing list.